Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2A11B200CD0 for ; Tue, 11 Jul 2017 07:18:43 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 288681651D8; Tue, 11 Jul 2017 05:18:43 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6CD701651D6 for ; Tue, 11 Jul 2017 07:18:42 +0200 (CEST) Received: (qmail 66441 invoked by uid 500); 11 Jul 2017 05:18:41 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 66412 invoked by uid 99); 11 Jul 2017 05:18:41 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Jul 2017 05:18:41 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id BB81E19548D for ; Tue, 11 Jul 2017 05:18:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id H7DLTFBl15Bn for ; Tue, 11 Jul 2017 05:18:40 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 5403162740 for ; Tue, 11 Jul 2017 04:53:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v6B4r1ih007126; Tue, 11 Jul 2017 04:53:01 GMT Message-Id: <201707110453.v6B4r1ih007126@ip-10-146-233-104.ec2.internal> Date: Tue, 11 Jul 2017 04:53:01 +0000 From: "Mostafa Mokhtar (Code Review)" To: Thomas Tauber-Marshall , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Matthew Jacobs , Tim Armstrong , Dan Hecht , Zach Amsden Reply-To: mmokhtar@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5498=3A_Support_for_partial_sorts=0A?= X-Gerrit-Change-Id: Ieec2a15a0cc5240b1c13682067ab64670d1e0a38 X-Gerrit-ChangeURL: X-Gerrit-Commit: 4b4f78175627ace41e88248fd6ebd90c9366ae4b In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 11 Jul 2017 05:18:43 -0000 Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-5498: Support for partial sorts ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7267/4/fe/src/main/java/org/apache/impala/planner/Planner.java File fe/src/main/java/org/apache/impala/planner/Planner.java: Line 527: if (!insertStmt.hasNoClusteredHint() && !ctx_.isSingleNodeExec()) { Why is this limited to Kudu? Inserting into Partitioned HDFS tables is a very common use case. -- To view, visit http://gerrit.cloudera.org:8080/7267 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieec2a15a0cc5240b1c13682067ab64670d1e0a38 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zach Amsden Gerrit-HasComments: Yes