Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201707080048.v680mImG032409@ip-10-146-233-104.ec2.internal>
Date: Sat, 8 Jul 2017 00:48:18 +0000
From: "Tim Armstrong (Code Review)" <gerrit@cloudera.org>
To: Bikramjeet Vig <bikramjeet.vig@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Matthew Jacobs <mj@cloudera.com>
Reply-To: tarmstrong@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5240=3A_Allow_config_of_number_of_disk_I/O_threads_per_disk_type=0A?=
In-Reply-To: <gerrit.1497984125000.I094aff3747104104fe0465d73dcdbef5d9892f7c@gerrit.cloudera.org>
References: <gerrit.1497984125000.I094aff3747104104fe0465d73dcdbef5d9892f7c@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
archived-at: Sat, 08 Jul 2017 00:48:24 -0000

Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5240: Allow config of number of disk I/O threads per disk type
......................................................................


Patch Set 9:

(2 comments)

Overall looks good to me, just a couple of minor things.

http://gerrit.cloudera.org:8080/#/c/7232/9/be/src/runtime/disk-io-mgr.cc
File be/src/runtime/disk-io-mgr.cc:

PS9, Line 53: string num_io_threads_per_rotational_disk_help_msg = Substitute("Number of I/O threads"
            :     " per rotational disk. Has priority over num_threads_per_disk. If neither is set, "
            :     "defaults to $0 thread(s) per rotational disk", THREADS_PER_ROTATIONAL_DISK);
            : DEFINE_int32(num_io_threads_per_rotational_disk, 0,
            :     num_io_threads_per_rotational_disk_help_msg.c_str());
> hm I just played around with this and it doesn't actually work, which makes
You could maybe define the constants with a #define and then stringify the values:

https://gcc.gnu.org/onlinedocs/gcc-3.4.3/cpp/Stringification.html


PS9, Line 271: deafult_val
typo: default


-- 
To view, visit http://gerrit.cloudera.org:8080/7232
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I094aff3747104104fe0465d73dcdbef5d9892f7c
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes