Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DA016200CCB for ; Thu, 6 Jul 2017 06:18:49 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D85951653E1; Thu, 6 Jul 2017 04:18:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2A98F1653DE for ; Thu, 6 Jul 2017 06:18:49 +0200 (CEST) Received: (qmail 6554 invoked by uid 500); 6 Jul 2017 04:18:48 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 6540 invoked by uid 99); 6 Jul 2017 04:18:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Jul 2017 04:18:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id AB33C1A0206 for ; Thu, 6 Jul 2017 04:18:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 2UpFinP-l1Bw for ; Thu, 6 Jul 2017 04:18:47 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 520705FB40 for ; Thu, 6 Jul 2017 04:18:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v664IhFU025297; Thu, 6 Jul 2017 04:18:43 GMT Message-Id: <201707060418.v664IhFU025297@ip-10-146-233-104.ec2.internal> Date: Thu, 6 Jul 2017 04:18:43 +0000 From: "Donghui Xu (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Jim Apple , Henry Robinson , Bharath Vissapragada Reply-To: xu.donghui@zte.com.cn X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5507=3A_Add_clear_description_to_help_information_of_KEYVAL_option=0A?= X-Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63 X-Gerrit-ChangeURL: X-Gerrit-Commit: 78378f9f3ee82e2e72da799897dad66308df7835 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 06 Jul 2017 04:18:50 -0000 Donghui Xu has posted comments on this change. Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option ...................................................................... Patch Set 6: (1 comment) I hava added description about underscores. Than you. http://gerrit.cloudera.org:8080/#/c/7179/5/shell/option_parser.py File shell/option_parser.py: Line 164: " contains alphanumeric characters or underscores.") > This actually is incorrect - it can also contain underscores. Sorry for missing underline. -- To view, visit http://gerrit.cloudera.org:8080/7179 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Donghui Xu Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Donghui Xu Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Jim Apple Gerrit-HasComments: Yes