Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6D75D200CCB for ; Thu, 6 Jul 2017 06:05:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6BCC41624B4; Thu, 6 Jul 2017 04:05:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B1382161838 for ; Thu, 6 Jul 2017 06:05:03 +0200 (CEST) Received: (qmail 98213 invoked by uid 500); 6 Jul 2017 04:05:02 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 98195 invoked by uid 99); 6 Jul 2017 04:05:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Jul 2017 04:05:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 029E7180A5A for ; Thu, 6 Jul 2017 04:05:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id eTboLTEnTOWP for ; Thu, 6 Jul 2017 04:05:01 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 041E75FC97 for ; Thu, 6 Jul 2017 04:05:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v6644x6x024969; Thu, 6 Jul 2017 04:04:59 GMT Message-Id: <201707060404.v6644x6x024969@ip-10-146-233-104.ec2.internal> Date: Thu, 6 Jul 2017 04:04:59 +0000 From: "Donghui Xu (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Henry Robinson , Sailesh Mukil , Bharath Vissapragada Reply-To: xu.donghui@zte.com.cn X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5514=3A_Throw_an_error_when_--ldap_password_cmd_is_used_without_LDAP_auth=0A?= X-Gerrit-Change-Id: I3711d8a0eca2fa8612e2943fa9121945db6b012e X-Gerrit-ChangeURL: X-Gerrit-Commit: 3f47be1e4186a21599323cb201eaacc23d6ddfc0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 06 Jul 2017 04:05:04 -0000 Donghui Xu has posted comments on this change. Change subject: IMPALA-5514: Throw an error when --ldap_password_cmd is used without LDAP auth ...................................................................... Patch Set 3: (3 comments) Thank you for the suggestion. I have modified the code. http://gerrit.cloudera.org:8080/#/c/7188/2//COMMIT_MSG Commit Message: PS2, Line 7: Throw an error when --ldap_password_cmd is used with > Sorry for nitpicking, I don't think judgement is the right word here. How a Done PS2, Line 11: > nit: Please remove trailing spaces (here and below) Done http://gerrit.cloudera.org:8080/#/c/7188/2/shell/impala_shell.py File shell/impala_shell.py: PS2, Line 1333: Option --ldap_password_cmd requires using LDAP authentication m > IMO something like "Option --ldap_password_cmd requires using LDAP authenti Done -- To view, visit http://gerrit.cloudera.org:8080/7188 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3711d8a0eca2fa8612e2943fa9121945db6b012e Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Donghui Xu Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Donghui Xu Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: Yes