Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201707052100.v65L0HQU014897@ip-10-146-233-104.ec2.internal>
Date: Wed, 5 Jul 2017 21:00:17 +0000
From: "Zach Amsden (Code Review)" <gerrit@cloudera.org>
To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org
CC: Jim Apple <jbapple-impala@apache.org>, David Knupp <dknupp@cloudera.com>,
        Joe McDonnell <joemcdonnell@cloudera.com>
Reply-To: zamsden@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Complete_guide_to_important_environment_variables_for_build=2C_test=2C_and_mini-cluster_operations=2E=0A?=
In-Reply-To: <gerrit.1498880781000.I16d34cb4fa0c60c5ad6d9c8764cc0ec21c5cb368@gerrit.cloudera.org>
References: <gerrit.1498880781000.I16d34cb4fa0c60c5ad6d9c8764cc0ec21c5cb368@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
archived-at: Wed, 05 Jul 2017 21:00:23 -0000

Zach Amsden has posted comments on this change.

Change subject: Complete guide to important environment variables for build, test, and mini-cluster operations.
......................................................................


Patch Set 1:

(2 comments)

> > I personally abhor Google docs as they just seem to get lost in
 > the
 > > Wiki-sea over time.  If we are going to take time to document the
 > > various set of environment variables controlling important
 > aspects
 > > of the build, why not make that accessible to both the internal
 > and
 > > external developers by including it in the codebase.
 > >
 > > This is my first draft of the standard build settings.
 > 
 > What about the Wiki, like this page: https://cwiki.apache.org/confluence/display/IMPALA/Bootstrapping+an+Impala+Development+Environment+From+Scratch

Our wikis are pretty nice, and for things like ASAN, totally worth documenting separately, but for non-major features, keeping this up to date still requires updating things in two places.  In experience, this isn't something people will do reliably unless forced.  I think we could force at least minimal documentation by keeping a white-list of exported build variables and enforcing it with a pre-checkin lint rule.

http://gerrit.cloudera.org:8080/#/c/7350/1/bin/impala-config.sh
File bin/impala-config.sh:

Line 440
> Speaking confidently as the only team member with a fine arts education, I'
Glad to know that my alternative career as the artist Deth Leprikon remains a well kept secret.


http://gerrit.cloudera.org:8080/#/c/7350/1/docs/Developer-Guide/Build-Environment.txt
File docs/Developer-Guide/Build-Environment.txt:

Line 1: Environment Variables:
> How many of these are set in impala-config.sh, and how many are set by othe
Additional docs will be forthcoming


-- 
To view, visit http://gerrit.cloudera.org:8080/7350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16d34cb4fa0c60c5ad6d9c8764cc0ec21c5cb368
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: Yes