Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201707051653.v65Gr9i6009091@ip-10-146-233-104.ec2.internal>
Date: Wed, 5 Jul 2017 16:53:09 +0000
From: "David Knupp (Code Review)" <gerrit@cloudera.org>
To: Zach Amsden <zamsden@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Jim Apple <jbapple-impala@apache.org>,
        Joe McDonnell <joemcdonnell@cloudera.com>
Reply-To: dknupp@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Complete_guide_to_important_environment_variables_for_build=2C_test=2C_and_mini-cluster_operations=2E=0A?=
In-Reply-To: <gerrit.1498880781000.I16d34cb4fa0c60c5ad6d9c8764cc0ec21c5cb368@gerrit.cloudera.org>
References: <gerrit.1498880781000.I16d34cb4fa0c60c5ad6d9c8764cc0ec21c5cb368@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
archived-at: Wed, 05 Jul 2017 16:53:14 -0000

David Knupp has posted comments on this change.

Change subject: Complete guide to important environment variables for build, test, and mini-cluster operations.
......................................................................


Patch Set 1:

(2 comments)

Whether it's a .txt file in the code base, or a wiki entry, how can we make sure that this doc stays in sync with impala-config.sh (and/or any other place where env vars get set)? We'd have multiple sources of truth, wouldn't we?

http://gerrit.cloudera.org:8080/#/c/7350/1/bin/impala-config.sh
File bin/impala-config.sh:

Line 440
Speaking confidently as the only team member with a fine arts education, I'm shocked that I did not know this setting existed. :-)


http://gerrit.cloudera.org:8080/#/c/7350/1/docs/Developer-Guide/Build-Environment.txt
File docs/Developer-Guide/Build-Environment.txt:

Line 1: Environment Variables:
How many of these are set in impala-config.sh, and how many are set by other means?


-- 
To view, visit http://gerrit.cloudera.org:8080/7350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16d34cb4fa0c60c5ad6d9c8764cc0ec21c5cb368
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: Yes