Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3A56F200CB9 for ; Sun, 2 Jul 2017 18:23:52 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 26667160BEE; Sun, 2 Jul 2017 16:23:52 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6C1C6160BD7 for ; Sun, 2 Jul 2017 18:23:51 +0200 (CEST) Received: (qmail 31894 invoked by uid 500); 2 Jul 2017 16:23:50 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 31883 invoked by uid 99); 2 Jul 2017 16:23:50 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 02 Jul 2017 16:23:50 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id CA81CC04BC for ; Sun, 2 Jul 2017 16:23:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id UNRdcynsAorP for ; Sun, 2 Jul 2017 16:23:49 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 1CAC95FDA5 for ; Sun, 2 Jul 2017 16:23:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v62GNgvk029720; Sun, 2 Jul 2017 16:23:42 GMT Message-Id: <201707021623.v62GNgvk029720@ip-10-146-233-104.ec2.internal> Date: Sun, 2 Jul 2017 16:23:42 +0000 From: "Jim Apple (Code Review)" To: Jim Apple , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Michael Ho Reply-To: jbapple-impala@apache.org X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5031=3A_Set_DiskIoMgr=3A=3AScanRange=3A=3Ais_cancelled__before_read=0A?= X-Gerrit-Change-Id: I22898ec96ac44c4902f8072f27453cfc58358cae X-Gerrit-ChangeURL: X-Gerrit-Commit: b71e1f06229c815e0f1e4411247fcf7b88688cb8 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Sun, 02 Jul 2017 16:23:52 -0000 Jim Apple has posted comments on this change. Change subject: IMPALA-5031: Set DiskIoMgr::ScanRange::is_cancelled_ before read ...................................................................... Patch Set 2: (1 comment) Had to rebase to pick up IMPALA-5594, which fixed a broken build with newer Kudu JARs. http://gerrit.cloudera.org:8080/#/c/7294/2/be/src/runtime/disk-io-mgr.h File be/src/runtime/disk-io-mgr.h: PS2, Line 584: is_cancelled_ = false; > Actually, shouldn't this be done in Reset() instead ? I would prefer to keep this patch within the bounds of only fixing the undefined behavior; I'd suggest that meaningful changes like changing the behavior of Reset() would best fit in a different patch. Thoughts? In the meantime, I have initialized all other bool flags, as you have suggested. -- To view, visit http://gerrit.cloudera.org:8080/7294 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22898ec96ac44c4902f8072f27453cfc58358cae Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Michael Ho Gerrit-HasComments: Yes