impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5696: Enable cipher configuration when using TLS / Thrift
Date Thu, 27 Jul 2017 22:51:48 GMT
Henry Robinson has uploaded a new change for review.

Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift

IMPALA-5696: Enable cipher configuration when using TLS / Thrift

The 'cipher suite' is a description of the set of algorithms used by SSL
and TLS to execute key exchange, encryption, message authentication, and
random number generation functions. SSL implementations allows the
cipher suite to be configured so that ciphers may be removed from the
whitelist if they are shown to be weak.

* Add a flag --ssl_cipher_list which controls cipher selection for both
  thrift servers and clients. Default is blank, which means use all
  available cipher suites.
* Add ThriftServerBuilder to simplify construction of
  ThriftServers (whose constructors were otherwise getting very long).

Testing: new tests added to thrift-server-test. Test cases added follow:

* A client cannot connect to a server which does not have any ciphers in
  common with it.
* If ciphers are identical on clients and servers, that ssl connections
  can be made.
* Bad cipher strings lead to errors on both client and server.

Change-Id: I735ae36eebfdf7228f235686c9c69642c3c9d84f
M be/src/benchmarks/
M be/src/catalog/
M be/src/rpc/
M be/src/rpc/
M be/src/rpc/
M be/src/rpc/thrift-server.h
M be/src/runtime/
M be/src/service/
M be/src/statestore/
M be/src/statestore/
M be/src/testutil/
A be/src/testutil/scoped-flag-setter.h
M be/src/util/
13 files changed, 399 insertions(+), 144 deletions(-)

  git pull ssh:// refs/changes/24/7524/1
To view, visit
To unsubscribe, visit

Gerrit-MessageType: newchange
Gerrit-Change-Id: I735ae36eebfdf7228f235686c9c69642c3c9d84f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <>

View raw message