impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5716: Don't delete cmake modules/* when enabling distcc
Date Tue, 25 Jul 2017 00:51:23 GMT
Henry Robinson has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7493

Change subject: IMPALA-5716: Don't delete cmake_modules/* when enabling distcc
......................................................................

IMPALA-5716: Don't delete cmake_modules/* when enabling distcc

If $IMPALA_HOME ends with a /, the clean_cmake_files function in
distcc_env.sh will emit a find command with a double // at the end for
the cmake_modules directory, and since it contains the substring cmake,
find will match and delete its contents.

Fix is to strip trailing /s from IMPALA_HOME in that method.

Testing: manually ran enable_distcc, obsErved that my files were still
there.

Change-Id: I8a6e34bedf8000aed9e2b0597cfe86f73222c6ed
---
M bin/clean.sh
M bin/distcc/distcc_env.sh
2 files changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/7493/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a6e34bedf8000aed9e2b0597cfe86f73222c6ed
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>

Mime
View raw message