impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [native-toolchain-CR] Remove Kudu build workaround for llvm stdlib path
Date Mon, 24 Jul 2017 16:49:09 GMT
Matthew Jacobs has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7485

Change subject: Remove Kudu build workaround for llvm stdlib path
......................................................................

Remove Kudu build workaround for llvm stdlib path

We previously had to work around a Kudu build limitation,
KUDU-2068, where Kudu would let llvm find the gcc toolchain
path. While this was building, this could lead to crashes at
runtime due to incompatible stdlibs. The toolchain build
worked around this by modifying
src/kudu/codegen/CMakeLists.txt

KUDU-2068 fixes this in Kudu.

As of Kudu commit bd61f2d57f195baa5b88c7f3183a50099b828eaf
(and 27854fd for SLES12SP0 which requires an additional fix)
he workaround is no longer necessary.

This also bumps the Kudu version to a version which includes
this fix.

Change-Id: I0078f2b80fb1e3429fb75fa0e654722bdc5c1f47
---
M buildall.sh
M source/kudu/build.sh
2 files changed, 1 insertion(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/85/7485/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7485
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0078f2b80fb1e3429fb75fa0e654722bdc5c1f47
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>

Mime
View raw message