impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5657: Fix a couple of bugs with FunctionCallExpr and IGNORE NULLS
Date Thu, 13 Jul 2017 19:37:56 GMT
Bharath Vissapragada has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7416

Change subject: IMPALA-5657: Fix a couple of bugs with FunctionCallExpr and IGNORE NULLS
......................................................................

IMPALA-5657: Fix a couple of bugs with FunctionCallExpr and IGNORE NULLS

Bugs:

- FunctionCallExpr's toSql() doesn't include IGNORE NULLS if present
  causing view definitions to break and leading to incorrect results.

- FunctionCallExpr's clone() implementation doesn't carry forward
  IGNORE NULLS option if present. One case that breaks with this is
  querying views containing analytic exprs causing wrong plans.

Fixed both the bugs and added a test that can reliably reproduce this.

Change-Id: I723897886c95763c3f29d6f24c4d9e7d43898ade
---
M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java
M testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test
2 files changed, 27 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/7416/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I723897886c95763c3f29d6f24c4d9e7d43898ade
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>

Mime
View raw message