impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taras Bobrovytsky (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5650: Make sum init zero a SUM function
Date Wed, 12 Jul 2017 02:10:13 GMT
Taras Bobrovytsky has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7404

Change subject: IMPALA-5650: Make sum_init_zero a SUM function
......................................................................

IMPALA-5650: Make sum_init_zero a SUM function

The recent Parquet count(*) optimization introduced a new aggregate
function sum_init_zero(). This caused an issue for non partitioned
aggregation node, which checks that the function type is either count,
min, max, sum or ndv. Since sum_init_zero() was not labelled as a sum()
function, a DCHECK was hit. This issue is fixed by labelling
sum_init_zero() as a sum() function.

Testing:
- Verified that we no longer hit a DCHECK when running a query with a
  Parquet count(*) optimization with legacy agg node enabled.

Change-Id: Ibca53e3ef6bad5283550100b33db55d674cff0b9
---
M be/src/exprs/agg-fn.cc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/7404/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7404
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibca53e3ef6bad5283550100b33db55d674cff0b9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <tbobrovytsky@cloudera.com>

Mime
View raw message