impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5744: Add dummy 'use krpc' flag and create DataStream interface
Date Mon, 31 Jul 2017 22:51:34 GMT
Sailesh Mukil has uploaded a new patch set (#3).

Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface
......................................................................

IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface

This patch introduces a dummy 'use_krpc' flag and creates an abstract
interface for the DataStreamSender/Recvr/Mgr.

The current DataStreamSender/Recvr/Mgr are renamed to
ThriftDataStream* and inherit from the new abstract DataStream*
interface.

The DataStreamRecvr::SenderQueue is not a nested class anymore and
is converted to SenderQueueBase which is an abstract class itself.
The ThriftDataStreamRecvr::SenderQueue implements the interface
exposed by SenderQueueBase.

The future KRPC patches will also implement the DataStream* interfaces
and the SenderQueueBase interface.

The 'use_krpc' flag defaults to 'false'. Cluster startup will abort
with an error if the flag is switched to 'true'.

DataStreamTest is renamed to ThriftDataStreamTest.

Change-Id: I5d52245154e910529a68f53049520238eca16241
---
M be/src/exec/data-sink.cc
M be/src/exec/exchange-node.cc
M be/src/runtime/CMakeLists.txt
M be/src/runtime/data-stream-mgr.cc
M be/src/runtime/data-stream-mgr.h
M be/src/runtime/data-stream-recvr.cc
M be/src/runtime/data-stream-recvr.h
M be/src/runtime/data-stream-sender.cc
M be/src/runtime/data-stream-sender.h
M be/src/runtime/exec-env.cc
M be/src/runtime/fragment-instance-state.cc
M be/src/runtime/runtime-state.cc
A be/src/runtime/sender-queue-base.h
A be/src/runtime/thrift-data-stream-mgr.cc
A be/src/runtime/thrift-data-stream-mgr.h
A be/src/runtime/thrift-data-stream-recvr.cc
A be/src/runtime/thrift-data-stream-recvr.h
A be/src/runtime/thrift-data-stream-sender.cc
A be/src/runtime/thrift-data-stream-sender.h
R be/src/runtime/thrift-data-stream-test.cc
M be/src/service/impala-server.cc
21 files changed, 1,503 insertions(+), 1,095 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/7542/3
-- 
To view, visit http://gerrit.cloudera.org:8080/7542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5d52245154e910529a68f53049520238eca16241
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>

Mime
View raw message