impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-1470: Fix error message with catalog down
Date Mon, 31 Jul 2017 22:13:57 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-1470: Fix error message with catalog down
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7539/3/be/src/service/fe-support.cc
File be/src/service/fe-support.cc:

Line 431:     status.ToThrift(&result.status);
> I think If status is OK then result is the value returned by Catalog server
We don't initialize result.status in that case - I think it's coincidence that it behaves
the same as if we'd set result.status to be OK.


-- 
To view, visit http://gerrit.cloudera.org:8080/7539
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic695faf89b146bdaa145aaca87f85579137b67c5
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang <twang@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <twang@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message