impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4795: Allow fetching function obj from catalog using signature
Date Mon, 31 Jul 2017 20:25:24 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-4795: Allow fetching function obj from catalog using signature
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7479/3/tests/common/impala_service.py
File tests/common/impala_service.py:

PS3, Line 240:   def get_catalog_object_dump(self, object_type, object_name):
             :     return self.read_debug_webpage('catalog_objects?object_type=%s&object_name=%s'
%\
             :         (object_type, object_name))
hm so then this is dead code. since this is the same function as we have on ImpaladService,
can you just move this to BaseImpalaService and override in StateStoredService to throw if
it's called there?


http://gerrit.cloudera.org:8080/#/c/7479/2/tests/query_test/test_udfs.py
File tests/query_test/test_udfs.py:

PS2, Line 580: 9998
> Fetched partial results (1 row) twice before this, so since the original qu
I see, thanks


-- 
To view, visit http://gerrit.cloudera.org:8080/7479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2cfad0213a79d39b77ad9aff701a93f93be4bf7f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message