impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tianyi Wang (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"
Date Sat, 29 Jul 2017 01:18:01 GMT
Tianyi Wang has posted comments on this change.

Change subject: IMPALA-3894: Change the behavior parsing date "YY"

Patch Set 8:

File be/src/exprs/

Line 159:   if (!context->IsArgConstant(1)) {
> We should be able to do this during the Prepare() phase of this function. I
File be/src/runtime/

Line 449:         if (tok_len <= 2) realign_year = true;
> You can do this on one line (see

PS4, Line 549: r parsed be YY, th
> Let's factor this common subexpression out into a separate variable for rea

Line 551:     date parsed_date(dt_result->year, dt_result->month, dt_result->day);
> Could you add a comment giving an example of what the value might be at thi

Line 555:     // For example if the century start at 1937 but dt_result->year = 1936,
> Could you add a comment giving an example of when we need to increment by 1
File be/src/runtime/timestamp-parse-util.h:

Line 139:   TimestampValue now;
> nit: add a "." for consistency with other comments.

Line 140: 
> Let's just store a copy of the TimestampValue inline instead of the pointer

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I5da761255915dc741f1dcc488fd4ef6ecc385896
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang <>
Gerrit-Reviewer: Greg Rahn <>
Gerrit-Reviewer: Tianyi Wang <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message