impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bikramjeet Vig (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-1891: Statestore won't send deletions in initial non-delta topic
Date Fri, 28 Jul 2017 17:35:59 GMT
Hello Henry Robinson,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/7527

to look at the new patch set (#2).

Change subject: IMPALA-1891: Statestore won't send deletions in initial non-delta topic
......................................................................

IMPALA-1891: Statestore won't send deletions in initial non-delta topic

Currently, when a subscriber connects to the statestore, its first
update contains the entire topic including deletions which are useless
because the subscriber has no base to apply those deletions to. This
patch ensures that the deletions are not included in that first update.

Testing:
Modified existing test case to include this check

Change-Id: I3fc525e1f3d960d642fc6356abb75f744cab7c33
---
M be/src/statestore/statestore.cc
M tests/statestore/test_statestore.py
2 files changed, 15 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/7527/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3fc525e1f3d960d642fc6356abb75f744cab7c33
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>

Mime
View raw message