impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5739 Correctly handle sles12 SP2
Date Fri, 28 Jul 2017 16:34:44 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5739 Correctly handle sles12 SP2
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/7535/1//COMMIT_MSG
Commit Message:

Line 7: IMPALA-5739 Correctly handle sles12 SP2
Nit: add a colon after the JIRA number.


Line 16: 
Can you mention testing briefly - I assume you did a full build on sles12 SP2? It's just good
to know since we don't have automated testing.


Line 18: Signed-off-by: Hector Acosta <hector.acosta@cloudera.com>
Can you remove the Signed-off-by?


-- 
To view, visit http://gerrit.cloudera.org:8080/7535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I005e05b8b66de78e6d53a35a894eb34d89843a62
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: hector.acosta@cloudera.com <hector.acosta@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message