impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taras Bobrovytsky (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5636: changed the format metadata of repetition level
Date Fri, 28 Jul 2017 07:20:29 GMT
Taras Bobrovytsky has posted comments on this change.

Change subject: IMPALA-5636: changed the format metadata of repetition level
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7514/2//COMMIT_MSG
Commit Message:

Line 7: IMPALA-5636: changed the format metadata of repetition level from bit_packing to RLE
Try to keep the subject line short (if possible, something like 50 characters)

Also, use the imperative mood in the subject line. i.e. replace the word "changed" with "Change".
Also, capitalize the first letter.

Give a brief description of the patch and why it's needed in the body of the commit message.


-- 
To view, visit http://gerrit.cloudera.org:8080/7514
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4112ec88e8f4050d28661d27f9227450288a6756
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang <twang@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <twang@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message