impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5009: Clean up test insert parquet.py
Date Thu, 27 Jul 2017 16:15:44 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-5009: Clean up test_insert_parquet.py
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7518/1/tests/query_test/test_insert_parquet.py
File tests/query_test/test_insert_parquet.py:

PS1, Line 351: tmpdir.strpath
> Adding on to Michael's comment, rather than passing the whole fixture aroun
+1 to this idea.


-- 
To view, visit http://gerrit.cloudera.org:8080/7518
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia84c78d7ff74cc7fdb3d782060caa5e52d0cd7d2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message