impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [native-toolchain-CR] IMPALA-5714: Add linker's version script for OpenSSL library
Date Thu, 27 Jul 2017 15:22:17 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5714: Add linker's version script for OpenSSL library
......................................................................


Patch Set 6: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7484/6/source/openssl/build.sh
File source/openssl/build.sh:

PS6, Line 48: $PWD/..
is there a better variable to use for this directory?


-- 
To view, visit http://gerrit.cloudera.org:8080/7484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72b39c5e15db268d35210c013e885f36764f1f89
Gerrit-PatchSet: 6
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message