impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bikramjeet Vig (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-1882: Remove ORDER BY restriction from first value()/last value()
Date Wed, 26 Jul 2017 23:42:37 GMT
Bikramjeet Vig has posted comments on this change.

Change subject: IMPALA-1882: Remove ORDER BY restriction from first_value()/last_value()
......................................................................


Patch Set 2:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/7502/1//COMMIT_MSG
Commit Message:

PS1, Line 14: Analyzer
> nit: Analyzer to be consistent with the actual code naming conventions
Done


http://gerrit.cloudera.org:8080/#/c/7502/1/fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java
File fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java:

PS1, Line 422:   }
             : 
             :   @Override
> make this a function like we do above for isXFn(), e.g. isOffsetFn(). No ne
Done


PS1, Line 454: : " + getFnCall().to
> then call that fn inline here
Done


PS1, Line 475: 
> also call the fn here
Done


http://gerrit.cloudera.org:8080/#/c/7502/1/testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test
File testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test:

Line 2012: ====
> Nice deterministic tests :)
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7502
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a3a56833ac062839629353ea240b361bc727d96
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message