impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gabor Kaszab (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5511: Add process start time to debug web page
Date Wed, 26 Jul 2017 11:07:40 GMT
Gabor Kaszab has posted comments on this change.

Change subject: IMPALA-5511: Add process start time to debug web page
......................................................................


Patch Set 11:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7363/11/be/src/util/default-path-handlers.cc
File be/src/util/default-path-handlers.cc:

PS11, Line 214: string GetProcessStartTime() {
              :   if (CommonMetrics::PROCESS_START_TIME == nullptr) {
              :     return "Error: Process start time can't be retrieved.";
              :   }
              :   return CommonMetrics::PROCESS_START_TIME->value();
              : }
> still would prefer you moved this into RootHandler - if CommonMetrics::PROC
Done


http://gerrit.cloudera.org:8080/#/c/7363/11/be/src/util/default-path-handlers.h
File be/src/util/default-path-handlers.h:

PS11, Line 40: /// Retrieves the process start time from CommonMetrics
             : string GetProcessStartTime();
> remove (callers should just check CommonMetrics::PROCESS_START_TIME).
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7363
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05ae2f80835b1b0e4bc3b38731778ba0871338a4
Gerrit-PatchSet: 11
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Gabor Kaszab <gaborkaszab@cloudera.com>
Gerrit-Reviewer: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <gaborkaszab@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <laszlo.gaal@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message