impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5716: Don't delete cmake modules/* when enabling distcc
Date Wed, 26 Jul 2017 03:36:40 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-5716: Don't delete cmake_modules/* when enabling distcc
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7493/1/bin/clean.sh
File bin/clean.sh:

Line 78: FIND_ARGS=("$IMPALA_HOME" -iname '*cmake*' -not -name CMakeLists.txt \
> How about we just switch to deleting a whitelist of files instead of trying
That seems better, I've done that (in fairly rudimentary bash, but I think it's sound).


-- 
To view, visit http://gerrit.cloudera.org:8080/7493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a6e34bedf8000aed9e2b0597cfe86f73222c6ed
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message