impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close()
Date Tue, 25 Jul 2017 21:13:05 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close()
......................................................................


Patch Set 1:

OK. Thanks for the clarification. This kind of implicit rule is always confusing to me.

I suppose this change makes sense to avoid the crash in release build if the MemTracker is
somehow referenced after it has been unlinked from its parent but before it's destroyed. On
the other hand, this makes me question if there are undesirable side-effect to allow such
references to the MemTracker object after it has been unlinked from the hierarchy.

-- 
To view, visit http://gerrit.cloudera.org:8080/7492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I205abb0076d1ffd08cb93c0f1671c8b81e7fba0f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message