impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close()
Date Tue, 25 Jul 2017 16:49:03 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close()
......................................................................


Patch Set 1: Code-Review+1

Seems like the right thing to do (i.e. control state cleanup happening in the destructor),
regardless of whether or not this fixes the crash in IMPALA-5715.

Let's see if Michael wants to take a look, but otherwise seems like a safe thing to commit.

-- 
To view, visit http://gerrit.cloudera.org:8080/7492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I205abb0076d1ffd08cb93c0f1671c8b81e7fba0f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message