impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [native-toolchain-CR] Add linker's version script for OpenSSL library.
Date Mon, 24 Jul 2017 20:18:30 GMT
Michael Ho has posted comments on this change.

Change subject: Add linker's version script for OpenSSL library.
......................................................................


Patch Set 4:

Answers to your questions:

1. I didn't try overriding LD_LIBRARY_PATH with other libraries in the toolchain so I cannot
tell if this is specific to OpenSSL.

2. This version script was actually from a patch file. If you download and unpack the file
mentioned in the commit message, you will find it in  patches/version-script.patch

3. Did you do ldd on statestored to see which libssl.so it was using ? If it's using the system
provided version (installed via apt-get install on Ubuntu), then it may have already been
compiled with the version script.

-- 
To view, visit http://gerrit.cloudera.org:8080/7484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72b39c5e15db268d35210c013e885f36764f1f89
Gerrit-PatchSet: 4
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message