impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [native-toolchain-CR] Add linker's version script for OpenSSL library.
Date Mon, 24 Jul 2017 19:38:05 GMT
Matthew Jacobs has posted comments on this change.

Change subject: Add linker's version script for OpenSSL library.
......................................................................


Patch Set 4:

Thanks, Michael. More questions:
1) is this only a requirement for OpenSSL on Debian? Do you have a reference where this is
explained or stated?
2) seems like 1.0.2g is close to our version, but is checking this in the right thing to do?
how do these version scripts get created? if they're generated, should we be generating it
as part of our build here so that it's more flexible?
3) I don't understand where the issue w/ starting the statestored occurs. I run a Debian-based
OS (Ubuntu 14.04) and have never seen this.

-- 
To view, visit http://gerrit.cloudera.org:8080/7484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72b39c5e15db268d35210c013e885f36764f1f89
Gerrit-PatchSet: 4
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message