impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [native-toolchain-CR] Add linker's version script for OpenSSL library.
Date Mon, 24 Jul 2017 19:23:47 GMT
Michael Ho has uploaded a new patch set (#4).

Change subject: Add linker's version script for OpenSSL library.
......................................................................

Add linker's version script for OpenSSL library.

Debian based distribution (e.g. Ubuntu) expects OpenSSL
dynamically linked library to have been compiled with
a version script to control the exported symbols for
different versions of the library. Without this version
info, one may get errors like the following:

$IMPALA_HOME/be/build/latest/statestore/statestored: $IMPALA_HOME/toolchain/openssl-1.0.1p/lib/libssl.so.1.0.0:
no version information available (required by $IMPALA_HOME/toolchain/kudu-1070e76/debug/lib/libkudu_client.so.0)

This change copies part of the version script of Ubuntu's libssl 1.0.2g
(https://launchpad.net/ubuntu/+archive/primary/+files/openssl_1.0.2g-1ubuntu11.2.debian.tar.xz)
and uses it as part of building the shared library.

Built Impala with this library and ran some sanity tests.

Change-Id: I72b39c5e15db268d35210c013e885f36764f1f89
---
M source/openssl/build.sh
A source/openssl/openssl.ld
2 files changed, 4,639 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/84/7484/4
-- 
To view, visit http://gerrit.cloudera.org:8080/7484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I72b39c5e15db268d35210c013e885f36764f1f89
Gerrit-PatchSet: 4
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>

Mime
View raw message