impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [native-toolchain-CR] Add linker's version script for OpenSSL library.
Date Mon, 24 Jul 2017 15:58:19 GMT
Matthew Jacobs has posted comments on this change.

Change subject: Add linker's version script for OpenSSL library.
......................................................................


Patch Set 2:

(1 comment)

what was happening when this wasn't included? can you add a link to show where this came from?
or however it was generated.

http://gerrit.cloudera.org:8080/#/c/7484/2/source/openssl/build.sh
File source/openssl/build.sh:

Line 36: OPENSSL_1.0.0 {
put this in a separate file? will make this script more manageable, and make the file more
easily version controlled.

e.g. maybe we need to have multiple versions, we could keep them in directories if needed,
like 1.0.0/openssl.ld


-- 
To view, visit http://gerrit.cloudera.org:8080/7484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72b39c5e15db268d35210c013e885f36764f1f89
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message