impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Remove spurious forward declarations and includes in coordinator.cc/h
Date Sat, 22 Jul 2017 08:10:28 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: Remove spurious forward declarations and includes in coordinator.cc/h
......................................................................


Remove spurious forward declarations and includes in coordinator.cc/h

While working on another patch, I noticed that a lot of includes and
forward declarations were spurious and possibly the result of bit rot.
This patch removes them and hopefully improves compile time a little.

Testing: Made sure that Impala and the BE tests compile successfully.

Change-Id: Id0afed224fad6a00698701487b51506d414f83ac
Reviewed-on: http://gerrit.cloudera.org:8080/7482
Reviewed-by: Sailesh Mukil <sailesh@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
2 files changed, 2 insertions(+), 22 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Sailesh Mukil: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/7482
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id0afed224fad6a00698701487b51506d414f83ac
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>

Mime
View raw message