impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5658: addtl. process/system-wide memory metrics
Date Sat, 22 Jul 2017 00:40:59 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-5658: addtl. process/system-wide memory metrics
......................................................................


Patch Set 2: Code-Review+2

(4 comments)

http://gerrit.cloudera.org:8080/#/c/7472/2/be/src/common/init.cc
File be/src/common/init.cc:

Line 148:     AggregateMemoryMetric::Refresh();
This won't get refreshed on the statestore or catalog service because of line 131 - so maybe
move this before that?


http://gerrit.cloudera.org:8080/#/c/7472/2/be/src/util/mem-info.h
File be/src/util/mem-info.h:

Line 32:   // Total size of memory maps (i.e. virtual memory size) in kilobytes.
nit: blank line before comments makes it easier to read.


http://gerrit.cloudera.org:8080/#/c/7472/2/be/src/util/memory-metrics.h
File be/src/util/memory-metrics.h:

PS2, Line 40: AggregateMemoryMetric
is it a big pain to rename this AggregateMemoryMetrics ? The name right now reads like it's
actually a subclass of Metric.


PS2, Line 77: value values
typo


-- 
To view, visit http://gerrit.cloudera.org:8080/7472
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13873e305ba464d11dea0d7244a29ff4f332f1a9
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message