impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anonymous Coward (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2782: Allow impala-shell to connect directly to impalad when configured with load balancer and kerberos.
Date Fri, 21 Jul 2017 21:49:24 GMT
andy@phdata.io has posted comments on this change.

Change subject: IMPALA-2782: Allow impala-shell to connect directly to impalad when configured
with load balancer and kerberos.
......................................................................


Patch Set 2:

I think we should use impalad[1] for the port still since then you'll still get the default
21000 if you specify nothing and its less you would have to enter for the -b flag. I also
question whether this should be called something like kerberos_host_name so its more inline
with kerberos_service_name change. 

host, port = self.lb.encode('ascii', 'ignore'), int(self.impalad[1])

-- 
To view, visit http://gerrit.cloudera.org:8080/7241
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4726226a7a3817421b133f74dd4f4cf8c52135f9
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vincent Tran <vttran@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vttran@cloudera.com>
Gerrit-Reviewer: andy@phdata.io
Gerrit-HasComments: No

Mime
View raw message