impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5546: Allow creating unpartitioned Kudu tables
Date Fri, 21 Jul 2017 20:33:47 GMT
Thomas Tauber-Marshall has posted comments on this change.

Change subject: IMPALA-5546: Allow creating unpartitioned Kudu tables
......................................................................


Patch Set 2:

> Nice! I like the warning. How about also a ctas test case?
 > 
 > I think it'd also be useful to move some of the smaller tables in
 > alltypes_kudu and tpch_kudu to be unpartitioned. a) because there's
 > no reason for the tiny tables to use the overhead and b) probably
 > more realistic for customer scenarios. Fine with me if you wanna do
 > that in a separate commit.

I made some tpch_kudu tables unpartitioned, and filed IMPALA-5693 for functional_kudu tables.

-- 
To view, visit http://gerrit.cloudera.org:8080/7446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I281f173dbec1484eb13434d53ea581a0f245358a
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message