impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kim Jin Chul (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()
Date Fri, 21 Jul 2017 15:36:41 GMT
Kim Jin Chul has posted comments on this change.

Change subject: IMPALA-5529: Add additional function signatures for TRUNC()
......................................................................


Patch Set 2:

(2 comments)

Thanks for all your reviews!

http://gerrit.cloudera.org:8080/#/c/7450/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java:

PS2, Line 2197:     AnalyzesOk("select truncate(cast(1.123 as decimal(10,3)))");
              :     AnalyzesOk("select truncate(cast(1.123 as decimal(10,3)), 0)");
              :     AnalyzesOk("select truncate(cast(1.123 as decimal(10,3)), 2)");
              :     AnalyzesOk("select truncate(cast(1.123 as decimal(10,3)), 5)");
              :     AnalyzesOk("select truncate(cast(1.123 as decimal(10,3)), -1)");
> can you wrap this in a loop to test these cases for each of truncate, dtrun
Done


Line 2240:     testDecimalExpr("truncate(1.23)", ScalarType.createDecimalType(1, 0));
> Similarly, wrap these in a loop.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I856da9f817b948de3c72af60a0742b128398b4cf
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Kim Jin Chul <jinchul@gmail.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Greg Rahn <grahn@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Kim Jin Chul <jinchul@gmail.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message