impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5627: fix dropped statuses in HDFS writers
Date Fri, 21 Jul 2017 02:51:52 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5627: fix dropped statuses in HDFS writers

IMPALA-5627: fix dropped statuses in HDFS writers

The change is mostly mechanical - added Status returns where

In one place I restructured the the logic around
'current_encoding_' for Parquet to allow a cleaner solution
to the dropped status from FinalizeCurrentPage() call in
ProcessValue(): after the restructuring the call was no longer
needed. 'current_encoding_' was overloaded to represent both the
encoding of the current page and the preferred encoding
for subsequent pages.

Ran exhaustive build.

Change-Id: I753d352c640faf5eaef650cd743e53de53761431
Reviewed-by: Tim Armstrong <>
Tested-by: Impala Public Jenkins
M be/src/exec/
M be/src/exec/hdfs-avro-table-writer.h
M be/src/exec/
M be/src/exec/hdfs-parquet-table-writer.h
M be/src/exec/
M be/src/exec/hdfs-table-writer.h
M be/src/exec/
M be/src/exec/parquet-column-stats.h
M be/src/exec/parquet-column-stats.inline.h
M be/src/runtime/
M be/src/runtime/string-buffer.h
11 files changed, 101 insertions(+), 74 deletions(-)

  Impala Public Jenkins: Verified
  Tim Armstrong: Looks good to me, approved

To view, visit
To unsubscribe, visit

Gerrit-MessageType: merged
Gerrit-Change-Id: I753d352c640faf5eaef650cd743e53de53761431
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Tim Armstrong <>

View raw message