impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vincent Tran (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format
Date Fri, 21 Jul 2017 01:50:35 GMT
Vincent Tran has posted comments on this change.

Change subject: IMPALA-5315: Cast to timestamp fails for YYYY-M-D format
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7009/5/be/src/runtime/timestamp-parse-util.cc
File be/src/runtime/timestamp-parse-util.cc:

Line 291:   // If we failed to parse using the default templates we will try lazy format.
> how much slower is it doing it this way, compared to using a stamped out fo
Virtually same over 11000 datetime strings. 
http://github.mtv.cloudera.com/gist/anonymous/a605d18c955198ecccda2c42d912d690

But maybe I need a larger dataset?


-- 
To view, visit http://gerrit.cloudera.org:8080/7009
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9a184a09d7e7783f04d47588537612c2ecec28f
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vincent Tran <vttran@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vttran@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message