impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bikramjeet Vig (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5275: Avoid printing status stack trace on hot paths
Date Thu, 20 Jul 2017 20:11:22 GMT
Bikramjeet Vig has posted comments on this change.

Change subject: IMPALA-5275: Avoid printing status stack trace on hot paths
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/7449/2/be/src/common/status.cc
File be/src/common/status.cc:

Line 48: Status::Status(TErrorCode::type code)
> It would be nice to have versions of Status::Expected() that took the prede
As Discussed, this change will not be a part of this commit


http://gerrit.cloudera.org:8080/#/c/7449/1/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

PS1, Line 663: 
> separate line, space after =
Done


PS1, Line 668: uard<mutex> l(query_log_lock_);
> Put this on a separate line for clarity/readability.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7449
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief083f558fba587381aa7fe8f99da279da02f1f2
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message