impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()
Date Thu, 20 Jul 2017 15:58:34 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5529: Add additional function signatures for TRUNC()
......................................................................


Patch Set 2:

(1 comment)

Thanks for doing this! Looks pretty good to me. Please make the 1 small test change, then
let's see if Thomas has any more feedback.

http://gerrit.cloudera.org:8080/#/c/7450/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java:

PS2, Line 2197:     AnalyzesOk("select truncate(cast(1.123 as decimal(10,3)))");
              :     AnalyzesOk("select truncate(cast(1.123 as decimal(10,3)), 0)");
              :     AnalyzesOk("select truncate(cast(1.123 as decimal(10,3)), 2)");
              :     AnalyzesOk("select truncate(cast(1.123 as decimal(10,3)), 5)");
              :     AnalyzesOk("select truncate(cast(1.123 as decimal(10,3)), -1)");
can you wrap this in a loop to test these cases for each of truncate, dtrunc, and trunc ?
They should all be the same.

e.g.

for (String fn : Lists.newArrayList("trunc", "dtrunc", "truncate")) {
... // cases using 'fn'


-- 
To view, visit http://gerrit.cloudera.org:8080/7450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I856da9f817b948de3c72af60a0742b128398b4cf
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Kim Jin Chul <jinchul@gmail.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Greg Rahn <grahn@cloudera.com>
Gerrit-Reviewer: Kim Jin Chul <jinchul@gmail.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message