impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5676: avoid expensive consistency checks in BTSv2
Date Thu, 20 Jul 2017 07:32:24 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-5676: avoid expensive consistency checks in BTSv2
......................................................................


Patch Set 3: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7459/3/be/src/runtime/buffered-tuple-stream-v2.cc
File be/src/runtime/buffered-tuple-stream-v2.cc:

PS3, Line 503: CHECK_CONSISTENCY_FAST();
If I understand it correctly, this should happen after all pages have been read so it should
be fine to use CHECK_CONSISTENCY_FULL(). Please feel free to leave it as-is though.


http://gerrit.cloudera.org:8080/#/c/7459/3/be/src/runtime/buffered-tuple-stream-v2.h
File be/src/runtime/buffered-tuple-stream-v2.h:

PS3, Line 695: uccess from a public API call. The Fast version
             :   /// has constant runtime. The Full version includes additional checks that
are O(n)
Why changed it back ?


-- 
To view, visit http://gerrit.cloudera.org:8080/7459
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8b380fcd0568cb73b36a490954bcd316db969ede
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message