impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5167: Reduce the number of Kudu clients created (FE)
Date Wed, 19 Jul 2017 21:47:40 GMT
Thomas Tauber-Marshall has posted comments on this change.

Change subject: IMPALA-5167: Reduce the number of Kudu clients created (FE)
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6898/4/testdata/workloads/functional-query/queries/QueryTest/kudu-timeouts-catalogd.test
File testdata/workloads/functional-query/queries/QueryTest/kudu-timeouts-catalogd.test:

Line 1: # TODO: enable this once we have a way to invalidate kudu clients (IMPALA-5685)
A few notes here:
- Moved to the top as the test file parser ignores 'headers'. Seemed like the cleanest way
to disable it.
- I renamed the table here as the test previously wasn't actually testing what its supposed
to - it was just returning the cached failed table load from the first query.
- The other tests in the file still work as the second and third tests are related to table
creation situations, where the table's metadata won't have been loaded by the previous query.


-- 
To view, visit http://gerrit.cloudera.org:8080/6898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b0b346f37ee43f7f0eefe34a093eddbbdcf2a5e
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Marcel Kornacker <marcelk@gmail.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message