impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case
Date Wed, 19 Jul 2017 21:01:25 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5582: Store sentry privileges in lower case
......................................................................


Patch Set 7:

(2 comments)

Thanks! 2 small things and otherwise I'm good to go. Let's make sure Michael Brown is also
OK with it.

http://gerrit.cloudera.org:8080/#/c/7332/7/tests/authorization/test_grant_revoke.py
File tests/authorization/test_grant_revoke.py:

PS7, Line 105: _y
technically this is still mixed case, no?


Line 168:       role_name = "test_role_" + get_random_id(5)
This line should be outside of the try loop, otherwise role_name isn't in scope at l192. Also,
if it fails, it doesn't need to execute the finally.


-- 
To view, visit http://gerrit.cloudera.org:8080/7332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide3dfa601fcf77f5acc6adce9bea443aea600901
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <aphadke@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: anujphadke <aphadke@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message