impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5670: Misc. tidying of ExecEnv
Date Wed, 19 Jul 2017 03:18:28 GMT
Hello Sailesh Mukil,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/7445

to look at the new patch set (#4).

Change subject: IMPALA-5670: Misc. tidying of ExecEnv
......................................................................

IMPALA-5670: Misc. tidying of ExecEnv

* Remove duplicated c'tor code for ExecEnv() and delegate it onto
  6-argument c'tor.
* Make some RM-related flags hidden
* Remove unused and untested 'use_statestore' branch in ExecEnv which
  created a scheduler with static hosts rather than those sent by the
  statestore.
* Remove corresponding scheduler c'tor to handle the above path.
* Remove unused 'use_statestore' parameter from
  InProcessImpalaServer::StartAsBackendOnly() and
  InProcessImpalaServer::StartWithClientServers().

Change-Id: I3886bc0edfae0c65c302e1a1812632e60668cd4c
---
M be/src/runtime/exec-env.cc
M be/src/runtime/exec-env.h
M be/src/scheduling/scheduler.cc
M be/src/scheduling/scheduler.h
M be/src/service/impalad-main.cc
M be/src/testutil/in-process-servers.cc
M be/src/testutil/in-process-servers.h
M be/src/testutil/mini-impala-cluster.cc
M docs/topics/impala_config_options.xml
M docs/topics/impala_upgrading.xml
10 files changed, 63 insertions(+), 173 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/45/7445/4
-- 
To view, visit http://gerrit.cloudera.org:8080/7445
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3886bc0edfae0c65c302e1a1812632e60668cd4c
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>

Mime
View raw message