impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5539: Fix Kudu timestamp with -use local tz for unix ts
Date Tue, 18 Jul 2017 20:56:02 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5539: Fix Kudu timestamp with -use_local_tz_for_unix_ts
......................................................................


Patch Set 4:

(2 comments)

LGTM aside from expanding the matrix of query options

http://gerrit.cloudera.org:8080/#/c/7311/4/tests/custom_cluster/test_local_tz_conversion.py
File tests/custom_cluster/test_local_tz_conversion.py:

Line 36:     self.run_test_case('QueryTest/utc-timestamp-functions', vector)
We should make sure to run this with the same test matrix as test_exprs - i.e. with codegen
enabled and disable and with expr rewrites enabled and disabled.


http://gerrit.cloudera.org:8080/#/c/7311/4/tests/query_test/test_exprs.py
File tests/query_test/test_exprs.py:

Line 150: class TestUtcTimestampFunctions(ImpalaTestSuite):
Should also run this with the same test dimensions as TestExprs


-- 
To view, visit http://gerrit.cloudera.org:8080/7311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I423a810427353be76aa64442044133a9a22cdc9b
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message