impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5275: Avoid printing status stack trace on hot paths
Date Tue, 18 Jul 2017 19:49:13 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5275: Avoid printing status stack trace on hot paths
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7449/1/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

PS1, Line 663: , is_query_missing =false;
separate line, space after =


PS1, Line 668: is_query_missing = query_record == query_log_index_.end()
Put this on a separate line for clarity/readability.


-- 
To view, visit http://gerrit.cloudera.org:8080/7449
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief083f558fba587381aa7fe8f99da279da02f1f2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message