impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Attila Jeges (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5407: Fix crash in HdfsSequenceTableWriter
Date Tue, 18 Jul 2017 18:41:46 GMT
Attila Jeges has posted comments on this change.

Change subject: IMPALA-5407: Fix crash in HdfsSequenceTableWriter
......................................................................


Patch Set 2:

(2 comments)

Added a test case to seq-writer.test and made sure that it crashes impalad if the fix is not
applied.

http://gerrit.cloudera.org:8080/#/c/7394/2//COMMIT_MSG
Commit Message:

PS2, Line 16: The issue is that HdfsSequenceTableWriter::Flush() frees the per-file
            : memory pool
> Please clarify that HdfsSequenceTableWriter::AppendRows() may call Flush() 
Done


PS2, Line 17: in use
> cached in the compressor
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7394
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida0b9f189175358ae54149d0e1af7caa06ae3bec
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message