impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5659: Begin standardizing treatment of thirdparty libraries
Date Mon, 17 Jul 2017 21:27:59 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-5659: Begin standardizing treatment of thirdparty libraries
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7418/3/CMakeLists.txt
File CMakeLists.txt:

PS3, Line 155: {BZIP2_STATIC_LIBRARIES
> This was just to ensure that the static lib was used in both cases - but th
Is there a reason to not just pass an empty string "" for the shared library in this case
? Please leave a comment if possible so future readers wouldn't naively think this is a typo
or something.


-- 
To view, visit http://gerrit.cloudera.org:8080/7418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7a6bc5610aaf2450f91348d94cfb984c6a4b78d
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message