impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "anujphadke (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case
Date Mon, 17 Jul 2017 20:31:32 GMT
anujphadke has posted comments on this change.

Change subject: IMPALA-5582: Store sentry privileges in lower case

Patch Set 4:

Commit Message:

PS3, Line 16: n update of the catalog object followed by a
            : removal of the old object. Since they both use the same key
> qq, Isn't this order always the same?
Verified that the order is always the same. Removal followed by additions.
Removed this comment.
File be/src/catalog/

PS3, Line 42:  
> nit space
File fe/src/main/java/org/apache/impala/catalog/

PS3, Line 336: trings.nullToEmpty(privilege.getUri()));
> s/ URIs are case sensitive ?
File fe/src/main/java/org/apache/impala/catalog/

Line 75:               toLowerCase()));
> nit: 4 space formatting everywhere
File tests/authorization/

Line 25: 
> It shouldn't be unless any is shadowed, which it ought not be. If it is, th

PS3, Line 129: 
> why not just 1 second?
setting this 1 and the sleep below to 2.

PS3, Line 130: assert any('test2' in x for x in
             :       assert any('test3' in x for x in
> Is this required?

Line 149:     """
> Could you also add some grants on camel case DB names?

PS3, Line 156:         grp.getgrnam(getuser()).gr_name))
             :     result = self.client.execute("show tables in functional")
             :     assert 'alltypes' in
             :     privileges_before = self.client.execute("show grant role test_role")
             :     # Wait a 
> I wonder if we can lower this if we reduce the sentry polling freq. Even a 

PS3, Line 165: verifier.wait_for_metric("catalog.ready", 
> How about adding it to a finally block incase the test fails, also clean up

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide3dfa601fcf77f5acc6adce9bea443aea600901
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <>
Gerrit-Reviewer: Bharath Vissapragada <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-Reviewer: Michael Brown <>
Gerrit-Reviewer: anujphadke <>
Gerrit-HasComments: Yes

View raw message