impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "anujphadke (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case
Date Mon, 17 Jul 2017 20:31:32 GMT
anujphadke has posted comments on this change.

Change subject: IMPALA-5582: Store sentry privileges in lower case
......................................................................


Patch Set 4:

(10 comments)

http://gerrit.cloudera.org:8080/#/c/7332/3//COMMIT_MSG
Commit Message:

PS3, Line 16: n update of the catalog object followed by a
            : removal of the old object. Since they both use the same key
> qq, Isn't this order always the same?
Verified that the order is always the same. Removal followed by additions.
Removed this comment.


http://gerrit.cloudera.org:8080/#/c/7332/3/be/src/catalog/catalog.cc
File be/src/catalog/catalog.cc:

PS3, Line 42:  
> nit space
Done


http://gerrit.cloudera.org:8080/#/c/7332/3/fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java
File fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java:

PS3, Line 336: trings.nullToEmpty(privilege.getUri()));
> s/ URIs are case sensitive ?
Done


http://gerrit.cloudera.org:8080/#/c/7332/3/fe/src/main/java/org/apache/impala/catalog/RolePrivilege.java
File fe/src/main/java/org/apache/impala/catalog/RolePrivilege.java:

Line 75:               toLowerCase()));
> nit: 4 space formatting everywhere
Done


http://gerrit.cloudera.org:8080/#/c/7332/3/tests/authorization/test_grant_revoke.py
File tests/authorization/test_grant_revoke.py:

Line 25: 
> It shouldn't be unless any is shadowed, which it ought not be. If it is, th
Done


PS3, Line 129: 
> why not just 1 second?
setting this 1 and the sleep below to 2.


PS3, Line 130: assert any('test2' in x for x in result.data)
             :       assert any('test3' in x for x in result.data)
> Is this required?
Removed.


Line 149:     """
> Could you also add some grants on camel case DB names?
Done


PS3, Line 156:         grp.getgrnam(getuser()).gr_name))
             :     result = self.client.execute("show tables in functional")
             :     assert 'alltypes' in result.data
             :     privileges_before = self.client.execute("show grant role test_role")
             :     # Wait a 
> I wonder if we can lower this if we reduce the sentry polling freq. Even a 
Done


PS3, Line 165: verifier.wait_for_metric("catalog.ready", 
> How about adding it to a finally block incase the test fails, also clean up
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide3dfa601fcf77f5acc6adce9bea443aea600901
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <aphadke@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: anujphadke <aphadke@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message