impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations
Date Fri, 14 Jul 2017 19:12:39 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5520: TopN node periodically reclaims old allocations
......................................................................


Patch Set 5:

(3 comments)

Looks good aside from some minor things. MJ, I'm ok if you want to +2 after the remaining
things are fixed.

http://gerrit.cloudera.org:8080/#/c/7400/5/be/src/exec/topn-node.cc
File be/src/exec/topn-node.cc:

PS5, Line 255: std::
Shouldn't be needed (common/names.h has "using std::unique_ptr").


http://gerrit.cloudera.org:8080/#/c/7400/5/be/src/exec/topn-node.h
File be/src/exec/topn-node.h:

PS5, Line 135: std::vector<Tuple*>&
Our convention is to pass modified arguments by pointer  - https://google.github.io/styleguide/cppguide.html#Reference_Arguments


PS5, Line 135: inline
Could be static, since it doesn't reference member variables.


-- 
To view, visit http://gerrit.cloudera.org:8080/7400
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I968f57f0ff2905bd581908bc5c5ee486b31e6aa8
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message