impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kim Jin Chul (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5116: Remove deprecated hash * types in gutil
Date Thu, 13 Jul 2017 21:58:18 GMT
Kim Jin Chul has posted comments on this change.

Change subject: IMPALA-5116: Remove deprecated hash_* types in gutil

Patch Set 2:


Thanks for your kind review. Would you please review again?
Commit Message:

PS1, Line 7: Remove deprecated hash_* types in gutil
> "Remove deprecated hash_* types in gutil"

PS1, Line 9: tut
> from

PS1, Line 9: class tem
> class templates
File be/src/gutil/hash/hash.h:

Line 222
> I don't think gcc ships with a std::hash overload for uint128. Why doesn't 
You're right. std::hash template class is specialized between 1 byte and 8 bytes. I agree
this is necessary for unsigned 16 bytes.

Line 278
> :
You're right. It should make wrong result or corruption.
File be/src/gutil/strings/split.h:

Line 135
> Has this fact about container-ism changed?
You're right. It's my mistake. pair cannot be a container.

Line 132: // multimap, unordered_set and unordered_map, and even std::pair which is not
> Fix early line break

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I06af30fd15acd43a60e3c30af54056c96520b6e9
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Kim Jin Chul <>
Gerrit-Reviewer: Jim Apple <>
Gerrit-Reviewer: Kim Jin Chul <>
Gerrit-HasComments: Yes

View raw message