impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kim Jin Chul (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5116: Remove deprecated hash * types in gutil
Date Thu, 13 Jul 2017 21:58:18 GMT
Kim Jin Chul has posted comments on this change.

Change subject: IMPALA-5116: Remove deprecated hash_* types in gutil
......................................................................


Patch Set 2:

(7 comments)

Thanks for your kind review. Would you please review again?

http://gerrit.cloudera.org:8080/#/c/7414/1//COMMIT_MSG
Commit Message:

PS1, Line 7: Remove deprecated hash_* types in gutil
> "Remove deprecated hash_* types in gutil"
Done


PS1, Line 9: tut
> from
Done


PS1, Line 9: class tem
> class templates
Done


http://gerrit.cloudera.org:8080/#/c/7414/1/be/src/gutil/hash/hash.h
File be/src/gutil/hash/hash.h:

Line 222
> I don't think gcc ships with a std::hash overload for uint128. Why doesn't 
You're right. std::hash template class is specialized between 1 byte and 8 bytes. I agree
this is necessary for unsigned 16 bytes.


Line 278
> http://en.cppreference.com/w/cpp/utility/hash :
You're right. It should make wrong result or corruption.


http://gerrit.cloudera.org:8080/#/c/7414/1/be/src/gutil/strings/split.h
File be/src/gutil/strings/split.h:

Line 135
> Has this fact about container-ism changed?
You're right. It's my mistake. pair cannot be a container.


Line 132: // multimap, unordered_set and unordered_map, and even std::pair which is not
> Fix early line break
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7414
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06af30fd15acd43a60e3c30af54056c96520b6e9
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Kim Jin Chul <jinchul@gmail.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Kim Jin Chul <jinchul@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message